✨feat(config) add option to customize commit message #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 added 'format' option in the configuration to be able to customize the commit message 📝 (readme) add customize commit message section BREAKING CHANGE: 💥 remove conventional config option (this is replaced by new customize commit message option)
This was referenced Oct 16, 2021
|
It's good to me. |
|
I made changes for my usage and pushed it to the dev-fixes branch, Adding custom format does not break conventional option |
ngryman
added a commit
that referenced
this pull request
Jul 24, 2022
…ominicrico * ✨ (config) add option to customize commit message 🔧 added 'format' option in the configuration to be able to customize the commit message 📝 (readme) add customize commit message section BREAKING CHANGE: 💥 remove conventional config option (this is replaced by new customize commit message option) * 🚧 tests for suggested code at #53 * 🐛 fix crash caused by an undefined config object * 🐛 only allow at most one space in the commit message * 🐛 do not override user provided format (thanks @dominicrico) Co-authored-by: André Augusto <andreaugustoqueiroz999@gmail.com>
ngryman
added a commit
that referenced
this pull request
Jul 24, 2022
…ominicrico for the fixes! * ✨ (config) add option to customize commit message 🔧 added 'format' option in the configuration to be able to customize the commit message 📝 (readme) add customize commit message section BREAKING CHANGE: 💥 remove conventional config option (this is replaced by new customize commit message option) * 🚧 tests for suggested code at #53 * 🐛 fix crash caused by an undefined config object * 🐛 only allow at most one space in the commit message * 🐛 do not override user provided format (thanks @dominicrico) Co-authored-by: André Augusto <andreaugustoqueiroz999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #53 became stale, so I finished it here.
Kudos to @AndreAugustoAAQ for starting this!
This PR mostly fixes a couple of regressions:
undefined.scope) can leave multiple consecutive whitespaces when not provided. I prevented multiple spaces in the finale commit message, which is I believe a good way to sanitize the message anyway.@AndreAugustoAAQ, @luizcorreia, @rossignolli Could you take a look at this as you were involved in the previous PR?
Thanks!
Fixes #51 #52 #53 #43 #31 #32