Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pullrequest #42

Merged
merged 35 commits into from
Jun 30, 2015
Merged

Pullrequest #42

merged 35 commits into from
Jun 30, 2015

Conversation

gamaanderson
Copy link
Contributor

This is United Pull Request (#28 #37 #39 #40 and #41)

changes include but do not restrict to:

  • remove the example plug-ins
  • improve window placement in standard script
  • add -F option to open file directly, no dialog
  • change standard field from 'reflectivity' to pyart.config.get_field_name('reflectivity')
  • add test to avoid breaking down doe to incorrect field
  • calculate_attenuation and phase_proc_lp plugins name to capital letters
  • add frames to the Menu layout elements
  • add option to have plugins in Menu or as Independent windows
  • clean radar_plot.py from historical "garbage"
  • remove --rhi and --airborne command line options
  • partial support to grid, including mapper plug-in and map_to_grid script
  • add -s command line option to define the script to execute
  • over all changes in documentation build with sphynx

@nguy you may merge this one

Anderson Gama and others added 30 commits May 13, 2015 16:49
revision
02b86d6
revision
9aaf39e
revision
569acf8
revision
3feccc8
change for RadarMapDisplay
4cd905c
add grid components
d48a0f8
Merge branch 'master' into issue_#18
cc583ff 
Conflicts:
	tools.py
plot_grid
94b61e3
execute_grid
1e981d5
Merge branch 'master' into issue_#32
8c06dfc
@gamaanderson
add mapper plugin
100e0b8
unknown commit
2c84ac9
complet mapper plugin
4147150
menu can work with grid or radar
2d40b3a
tilt window work with grid or radar
20960a4
improve placement
4ad9b1a
further development
c4f3553
Merge branch 'master' into issue_#32
383ebb5 
Conflicts:
	artview/components/menu.py
	artview/components/plot.py
	execute_two.py
Several small modification to improve user experience, including:
fc7cd09 
    remove the example plugins
    improve window placement in standard script
    add -F option to open file directly, no dialog
    change standard field from 'reflectivity' to
        pyart.config.get_field_name('reflectivity')
    add test to avoid breaking down dow to incorrect field
    calculate_attenuation and phase_proc_lp plugins name to
        capital letters
add frame to items in Menu
95354dc
improve plugin start
e82b3ad
convert to new import structure
14ae65d
Improve documentation build
ed8adc0
change __init__.py to get closer to pyart version
d2dcac6
@gamaanderson
fix issue 38 and improve over all how this is worked out
d777ddd
@gamaanderson
remove rhi and airborne options
51dc9ed
@gamaanderson
Merge branch 'issue_#18' of https://github.com/gamaanderson/artview i…
f137bcf 
…nto pullrequest

Conflicts:
	artview/components/plot_radar.py
	artview/components/tools.py
@gamaanderson
Merge branch 'issue_#32' of https://github.com/gamaanderson/artview i…
9295721 
…nto pullrequest

Conflicts:
	artview/components/__init__.py
	artview/components/plot_radar.py
Merge branch 'master' of https://github.com/gamaanderson/artview into…
4424dc5 
… pullrequest

Conflicts:
	artview/__main__.py
	artview/components/menu.py
	artview/components/plot_radar.py
	artview/core/common.py
	artview/parser.py
	artview/plugins/exemple1.py
	artview/plugins/exemple2.py
	setup.py
Merge branch 'documentation' of https://github.com/gamaanderson/artview…
2c2a38c 
… into pullrequest

Conflicts:
	artview/__init__.py
This was referenced Jun 29, 2015
Merged
Merged
@gamaanderson
Copy link
Contributor Author

Documentation may be found here, as soon as this is merge you may found it also here. This is not the way github suggest doing, but I couldn't get the suggested way to work.

@gamaanderson gamaanderson mentioned this pull request Jun 29, 2015
Closed
nguy
nguy reviewed Jun 29, 2015
View reviewed changes
artview/components/menu.py
msg = "This is not a recognized radar file!"
radar_warning = False
grid_warning = False
if self.mode in ("radar","all"):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "all" mean here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radar and grid

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha.

nguy
nguy reviewed Jun 30, 2015
View reviewed changes
artview/components/plot_radar.py
if ntilt < 0:
ntilt = len(self.rTilts)-1
elif ntilt >= len(self.rTilts):
ntilt = 0
self.Vtilt.change(ntilt)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on with the if statement here? When would ntilt be less than 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will and is happening when pressing down even if tilt already equal 0. Note this line has no test for that. The only reason we haven't notice this is because python is saving us by allowing negative index, now I'm just doing this looping around explicit, so I don't have to test Vtilt. Notice I have a list with valid values for the Vvariables, and Vtilt shouldn’t have negative values.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I had not caught this.

@nguy
Copy link
Owner

nguy commented Jun 30, 2015

Okay, I'm going to accept the changes. I've found a couple little bugs that I'll start as issues.
Otherwise, I think this looks great @gamaanderson !

@nguy nguy mentioned this pull request Jun 30, 2015
Closed
@nguy nguy merged commit 77c6b94 into nguy:master Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gamaanderson @nguy