Added anchors #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @nguyentype, have you seen this PR? |
|
Hi Emma,Can you guide me what I should do? 😁Thank you,Nguyen Type
On Wed, 24 May 2023 at 14:03 Emma wrote:
Hello @nguyentype, have you seen this PR?
It would be great if you can merge, so we can update the font :)
Cheers!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#4 (comment)",
"url": "#4 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
|
Sure! You can see the new version of the font in the PR, which come from a fork I created on my side: https://github.com/emmamarichal/vinasans And if you are ok with the changes I made, you can merge this Pull Request :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @nguyentype,
I'm Emma, I'm working with Yanone in the GF team. Yanone isn't available this week, so I help him here.
The font is now on the API, but we noticed a small issue with accents. See this issue: google/fonts#6226
So I just added anchors to accents and letters, to activate the right feature.
See the difference below:
Don't hesitate if you have any questions, once this PR is merged, we will onboard this update asap.
Cheers!
Emma