Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps php81 vardumper6 #10

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Conversation

fey
Copy link
Contributor

@fey fey commented Mar 26, 2022

Hello, i updated deps on my Laravel project. Its requre to update var-dumper.
I removed <7.4 versions php because its depricated.
Should be good idea release package tag, because changes can broke code for ppl who use phpower

@fey
Copy link
Contributor Author

fey commented Mar 30, 2022

@ngyuki hi, can use give feedback? :)

@ngyuki
Copy link
Owner

ngyuki commented Mar 31, 2022

@fey Thanks for the PR. Sorry for the delay in replying.

PHP 7.4 is not yet EOL and we do not want to remove it from support if possible.
I'll give it some thought.

@ngyuki ngyuki self-assigned this Mar 31, 2022
@fey
Copy link
Contributor Author

fey commented Mar 31, 2022

@ngyuki Hi, what do you think about v2 version?

@ngyuki
Copy link
Owner

ngyuki commented Mar 31, 2022

@fey What does "v2 version" mean?

@fey
Copy link
Contributor Author

fey commented Mar 31, 2022

@ngyuki i mean to create another branch to support two versions of phpower.
v1 (master) will work on 7.4
v2 (branch) will work 8.0+

@ngyuki
Copy link
Owner

ngyuki commented Mar 31, 2022

I would like to avoid that if possible...

Could these problems be solved with the following changes.

diff --git a/composer.json b/composer.json
index 19d6bd5..dc27954 100644
--- a/composer.json
+++ b/composer.json
@@ -14,11 +14,11 @@
         "sort-packages": true
     },
     "require": {
-        "php": ">=8.0",
+        "php": "^7.4|^8.0|^8.1",
         "ext-json": "*",
         "microsoft/tolerant-php-parser": "^0.1",
         "phpunit/phpunit": "^9.5",
-        "symfony/var-dumper": ">=6.0"
+        "symfony/var-dumper": "^5.3.7|^6.0"
     },
     "autoload": {
         "psr-4": {

@fey fey force-pushed the update-deps-php81-vardumper6 branch from 0e8da0f to 80a8622 Compare March 31, 2022 11:40
@fey
Copy link
Contributor Author

fey commented Mar 31, 2022

@ngyuki ty, i updated code.

@ngyuki
Copy link
Owner

ngyuki commented Mar 31, 2022

@fey Thank you!
I will push release tag later.

@ngyuki ngyuki merged commit 7bb9c0f into ngyuki:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants