fix DisableErrSkip() driver option (adds unit test) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhatthm
reviewed
May 22, 2023
driver_test.go
Outdated
| oteltest.New( | ||
| oteltest.MockDatabase(func(m sqlmock.Sqlmock) { | ||
| m.ExpectPing(). | ||
| WillReturnError(skipErr) |
There was a problem hiding this comment.
Can we just use driver.ErrSkip directly?
pmlanger
force-pushed
the
master
branch
2 times, most recently
from
5515152
to
7c76555
Compare
pmlanger
changed the title
|
@pmlanger Awesome, thanks for the tests 👍 |
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1217 1217
=========================================
Hits 1217 1217
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #207
It also adds a test. Let me know if it fits in well enough!