Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes need for Matrix objects as output of assay #43

Merged
merged 2 commits into from
Jun 15, 2018
Merged

Fixes need for Matrix objects as output of assay #43

merged 2 commits into from
Jun 15, 2018

Conversation

nhejazi
Copy link
Owner

@nhejazi nhejazi commented Jun 14, 2018

This PR fixes the issue reported in #42, which caught an out-of-date use of t() on the object produced by SummarizedExperiment::assay(), which (at least as of Bioconductor 3.7) returns an object of class DataFrame. In biomarkertmle(), t() and other downstream functions (e.g., limma::normalizeBetweenArrays()) require a Matrix-like object, a status for which DataFrame apparently does not qualify. This has been fixed by adding an explicit call to as.matrix. The opportunity is also taken to amend documentation and make other less-intrusive packaging changes.

Changes

  • explicitly coerce object returned by assay() to class Matrix
  • documentation updates + updates to pkgdown site
  • names of .R files have been amended for the sake of clarity
  • explicitly require all of S4Vectors via @import to satisfy pkgdown

@nhejazi
Copy link
Owner Author

nhejazi commented Jun 15, 2018

Merging despite failure on Bioc-devel.

@nhejazi
Copy link
Owner Author

nhejazi commented Jun 15, 2018

Closes #42

@nhejazi nhejazi merged commit e639335 into master Jun 15, 2018
@nhejazi nhejazi deleted the fix-#42 branch June 17, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant