Add Oracle to GitHub Actions #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
changed the title
hazzik
reviewed
Jul 12, 2021
hazzik
reviewed
Jul 13, 2021
hazzik
approved these changes
Jul 13, 2021
hazzik
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB: Oracle 18c (18.4.0) docker image
Client: Oracle.ManagedDataAccess.Core Version="2.19.110" (3.x doesn't support .net standard 2.0)
Dialect: NHibernate.Dialect.Oracle10gDialect (newer Oracle12cDialect dialect gives some failed tests)
NH1171 tests are skipped as it's Oracle client bug (also present in recent NETFX libs) - added #2853 for tracking
P.S. Oracle teamcity tests take 40 minutes to finish. Doesn't look right - if I remember correctly it was about 20 minutes some months/years back. I wonder if #1511 is a culprit - added #2854