Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve vue-calendar and react-calendar examples #1230

Merged
merged 4 commits into from
Jul 28, 2022
Merged

feat: improve vue-calendar and react-calendar examples #1230

merged 4 commits into from
Jul 28, 2022

Conversation

heenakwag
Copy link
Member

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • Improve vue-calendar and react-calendar examples.
  • Fix types and options for react-calendar.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

adhrinae
adhrinae approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lja1018
lja1018 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@heenakwag heenakwag merged commit 43586b3 into main Jul 28, 2022
@heenakwag heenakwag deleted the feat/improve-vue-example branch July 28, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhrinae adhrinae adhrinae approved these changes

@lja1018 lja1018 lja1018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heenakwag @adhrinae @lja1018