Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape backslash in the middle of sentence #2588

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • Fixed an issue where backslashes in the middle of sentences were not escaped.
    • In WYSIWYG, when a backslash was written in the middle of a sentence like some \<span>sentence</span>, the backslash was not escaped and the span tag was escaped.
    • In this case, by escaping the backslash, the content is converted to normal.

As-Is

To-Be


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@jajugoguma jajugoguma merged commit 3fc8ac5 into master Jul 5, 2022
@jajugoguma jajugoguma deleted the fix/escape-backslash-in-the-middle-of-sentence branch July 5, 2022 05:23
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
* test: add test for escape baskslash

* fix: escape backslash in the middle of sentence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants