Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define move direction on enter #1966

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

The moveDirectionOnEnter option now allows you to determine the direction of focus movement when the Enter key is pressed. Possible move directions are nextCell, prevCell, up, and down.

nextCell

It is same behavior as when the Tab key is pressed.

nextCell

prevCell

It is same behavior as when the Shift-Tab key is pressed.

prevCell

up

It is similar behavior as when the Arrow up key is pressed. The difference is that it also acts while editing (finishes editing), and will automatically start editing if the cell to get focus is an editable cell.

up

down

It is similar behavior as when the Arrow down key is pressed. The difference is that it also acts while editing (finishes editing), and will automatically start editing if the cell to get focus is an editable cell.

down


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

packages/toast-ui.grid/src/helper/keyboard.ts Show resolved Hide resolved
Copy link

@sunyoungBae sunyoungBae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다 고생하셨습니다

@jajugoguma jajugoguma merged commit 99c79d9 into master Sep 15, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the feat/moving-direciton-on-enter branch September 15, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants