Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: occur error when call validate with sort #1998

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Fixed an issue where using the validate API with sorting would result in an error.

This was caused by creating the viewDate directly from rawData without unobserving the rows that disappear outside the viewport when sorting.
This caused an error because it thought it was a row that was observable when in fact it was not, and did not convert it to observable.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma merged commit 1c65b04 into master Dec 13, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the fix/unobserve-during-sort branch December 13, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants