Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

브라우저 크기에 따라 캔버스의 크기가 재조정되어야 합니다. #12

Closed
kim-jeongki opened this issue Oct 27, 2016 · 2 comments
Closed

브라우저 크기에 따라 캔버스의 크기가 재조정되어야 합니다. #12

kim-jeongki opened this issue Oct 27, 2016 · 2 comments

Comments

@kim-jeongki
Copy link

기존 div.image-wrapper와 canvas의 높이와 넓이가 고정될경우
사용자의 환경 및 viewport 크기에 따라 화면 노출이 잘리거나 과다하게 작은 영역만 표시되어 불편함이 초래될 수 있을 듯 합니다.
특정 scale의 factor로 zoom In out 을 처리해주는 기능이 필요할 듯 합니다.
window.resize에 대한 처리는 외부에서 하는 게 좋을 것 같구요
@seonim-ryu
Copy link
Member

API 추가 여부를 검토하고 있으며, 서비스단에서 처리할 수 있는 경우 가이드 드리도록 하겠습니다.

@seonim-ryu seonim-ryu mentioned this issue Oct 28, 2016
Closed
@seonim-ryu
Copy link
Member

resizeCanvasDimension() API가 추가되었으며 API 문서 참조바랍니다.

lja1018 pushed a commit that referenced this issue Feb 8, 2021
@lja1018
Merge pull request #12 from nhnent/chore/change-company-name
e22ce4b 
chore: change company name(nhnent -> nhn)
lja1018 added a commit that referenced this issue Feb 22, 2021
@lja1018 @junghwan-park
@jinwoo-kim-nhn @jungeun-cho
feat: monorepo (#524)
2905f5f 
* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>
lja1018 added a commit that referenced this issue Feb 22, 2021
@lja1018 @junghwan-park
@jinwoo-kim-nhn @jungeun-cho
refactor: monorepo skeleton (#523)
0d21d3c 
* chore: make apps directory, move files to apps

* chore: fix test cases, misspellings and change NHN Ent to NHN

* chore: fix range tool options type

* feat: monorepo (#524)

* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>
lja1018 added a commit that referenced this issue Feb 22, 2021
@lja1018 @junghwan-park
@jinwoo-kim-nhn @jungeun-cho
feat: v3.12.0 (#529)
de4d7ac 
* refactor: monorepo skeleton (#523)

* chore: make apps directory, move files to apps

* chore: fix test cases, misspellings and change NHN Ent to NHN

* chore: fix range tool options type

* feat: monorepo (#524)

* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

* fix: not work filter in direct api example [#388] (#525)

* fix: classname error when clicking in the gap [#411] (#526)

* fix: not occur text changed event [#387, #419] (#527)

* fix: disappear image when apply crop [#359] (#528)

* env: fix editorconfig tabsize

* fix: image disappears when applying an empty cropzone (#359)

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kim-jeongki @seonim-ryu