Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: monorepo skeleton #523

Merged
merged 4 commits into from Feb 22, 2021
Merged

refactor: monorepo skeleton #523

merged 4 commits into from Feb 22, 2021

Conversation

lja1018
Copy link
Contributor

@lja1018 lja1018 commented Feb 8, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

모노레포 작업을 위해 apps/image-editor로 프로젝트 위치를 옮겼습니다

작업내역

  • 프로젝트 이동
  • alias 적용
  • 사명 변경(NHN Ent -> NHN) 적용
  • 기타 오탈자 수정

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

dongsik-yoo
dongsik-yoo reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 변경양이 많은데 고생하셨네요.

  • 커밋별로 작업이 분리가 되면 더 좋았겠습니다. 사명 변경 커밋, alias 작업 커밋, 파일 이동 커밋, 오타 수정 커밋, 린트오류 수정 등 작업별로 분류해서 PR을 날리거나, 최소한 커밋별로는 작업이 구분이 되는 것이 좋습니다.
  • 문자열, css 클래스이름 등등 오타 수정 관련해서 외부로 나가는 인터페이스의 이름이 변경되는건 아닌지 한번만 더 확인 부탁드릴게요.

apps/image-editor/karma.conf.js Show resolved Hide resolved
apps/image-editor/src/js/component/text.js Show resolved Hide resolved
apps/image-editor/src/js/extension/cropzone.js Show resolved Hide resolved
apps/image-editor/src/js/graphics.js Show resolved Hide resolved
junghwan-park
junghwan-park approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료입니다~~ 고생 많았어요 ㅎㅎ

jinwoo-kim-nhn
jinwoo-kim-nhn approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

양이 많네요 ㅎㅎ 수고하셨습니다. 저는 다른 의견은 없습니다

@lja1018 @junghwan-park
@jinwoo-kim-nhn @jungeun-cho
feat: monorepo (#524)
2905f5f 
* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>
@lja1018 lja1018 merged commit 0d21d3c into feat/v3.12.0 Feb 22, 2021
@lja1018 lja1018 deleted the refactor/monorepo-skeleton branch February 22, 2021 02:31
lja1018 added a commit that referenced this pull request Feb 22, 2021
@lja1018 @junghwan-park
@jinwoo-kim-nhn @jungeun-cho
feat: v3.12.0 (#529)
de4d7ac 
* refactor: monorepo skeleton (#523)

* chore: make apps directory, move files to apps

* chore: fix test cases, misspellings and change NHN Ent to NHN

* chore: fix range tool options type

* feat: monorepo (#524)

* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

* fix: not work filter in direct api example [#388] (#525)

* fix: classname error when clicking in the gap [#411] (#526)

* fix: not occur text changed event [#387, #419] (#527)

* fix: disappear image when apply crop [#359] (#528)

* env: fix editorconfig tabsize

* fix: image disappears when applying an empty cropzone (#359)

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsik-yoo dongsik-yoo dongsik-yoo left review comments

@junghwan-park junghwan-park junghwan-park approved these changes

@jinwoo-kim-nhn jinwoo-kim-nhn jinwoo-kim-nhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lja1018 @junghwan-park @dongsik-yoo @jinwoo-kim-nhn