Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: monorepo #524

Merged
merged 48 commits into from
Feb 22, 2021
Merged

feat: monorepo #524

merged 48 commits into from
Feb 22, 2021

Conversation

lja1018
Copy link
Contributor

@lja1018 lja1018 commented Feb 8, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • 모노레포를 적용했습니다.
  • react-wrapper, vue-wrapper는 README와 config 파일만 일부 수정했습니다.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

lja1018 and others added 30 commits February 5, 2021 10:50
@lja1018
chore: init lerna options
4db8e19
@junghwan-park @lja1018
chore: Docs
5dbc99c
@junghwan-park @lja1018
chore: Development environment
3cfec86
@junghwan-park @lja1018
interim
060d287
@junghwan-park @lja1018
feat: Add Storybook
8756157
@junghwan-park @lja1018
fix: Use uiSize option
835b234
@junghwan-park @lja1018
doc: Add README.md
aeeb769
@junghwan-park @lja1018
chore: Modify README.md
f8400e4
@junghwan-park @lja1018
chore: Modify README.md
36b031f
@junghwan-park @lja1018
chore: Bundle v1.0.0
ca09647
@lja1018
Merge branch 'master' into production
4a3c0e9
@lja1018
Merge branch 'master' into production
134b4e9
@lja1018
chore: version up v1.0.1
6d5cb19
@junghwan-park @lja1018
Merge branch 'master' into production
6431921
@junghwan-park @lja1018
chore: Bundle v1.1.0
78f9cf6
@jinwoo-kim-nhn @lja1018
Merge branch 'master' into production
4e36d87
@jinwoo-kim-nhn @lja1018
chore: Bundle v1.2.0
0dde568
@lja1018
Merge branch 'master' into production
5ee71bd 
# Conflicts:
#	.gitignore
@lja1018
Merge branch 'master' into production
6373044
@lja1018
chore: import react wrapper
024bc08
@lja1018
chore: check npm bundle, change comment
bcb7a8c
@lja1018
chore: update tuidoc config
d8cd005
@lja1018
chore: update tslint.json
eb7821a
@jungeun-cho @lja1018
feat: Implement vue wrapper for tui.ImageEditor
b7abe20
@jungeun-cho @lja1018
docs: add homepage, repository info
c28ca8d
@jungeun-cho @lja1018
Merge pull request #1 from nhnent/feat/example
cae11d0 
chore : add fast example using @vue/cli
@jungeun-cho @lja1018
fix: update vue/cli (Security vulnerability response)
f1e481f
@jungeun-cho @lja1018
chore: update v1.0.1
09ff52e
@jungeun-cho @lja1018
chore: update tui-image-editor version
73c731f
@jungeun-cho @lja1018
chore: update tilde dependency package version
7f3d7dc
@junghwan-park
Copy link
Member

@lja1018
음... 어째서 커밋 내역이 이렇게 구성되었을까요?
rebase를 잘못 하신걸까요?

이번 변경 내역은 아닌데 feat/monorepo가 오래된 커밋들을 다 가지고있네요.

@lja1018
Copy link
Contributor Author

lja1018 commented Feb 10, 2021

@junghwan-park
react-wrapper와 vue-wrapper의 git 히스토리를 현재 브랜치로 가져와서 그렇습니다!

jung-han
jung-han reviewed Feb 10, 2021
View reviewed changes
Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완료입니다. 뷰쪽 스토리북 추가하는 것과 리드미 재작성 해주시면 좋을 것 같습니다.

dongsik-yoo
dongsik-yoo reviewed Feb 10, 2021
View reviewed changes
Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 고생하셨어요.

apps/image-editor/index.d.ts Outdated Show resolved Hide resolved
apps/image-editor/index.d.ts Outdated Show resolved Hide resolved
apps/image-editor/package.json Outdated Show resolved Hide resolved
jinwoo-kim-nhn
jinwoo-kim-nhn approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

apps/image-editor/index.d.ts Outdated Show resolved Hide resolved
junghwan-park
junghwan-park reviewed Feb 10, 2021
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료입니다! 고생 많으셨어요 ㅎㅎ

seonim-ryu
seonim-ryu approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[2/10] 리뷰 완료합니다. 일단 모노레포 전체 구성은 다른 프로덕트를 참조해서 이상은 없어보입니다만, 배포 전에 로컬에서 빌드 및 설치가 잘 되는지 많이 테스트해보고 나갔으면 좋겠습니다. 혹시 배포가 어렵다면 이전에 모노레포를 배포했던 분들이랑 같이 배포 과정을 진행해도 괜찮을 것 같습니다. 고생하셨습니다~

@lja1018 lja1018 merged commit 2905f5f into refactor/monorepo-skeleton Feb 22, 2021
@lja1018 lja1018 deleted the feat/monorepo branch February 22, 2021 02:30
lja1018 added a commit that referenced this pull request Feb 22, 2021
@lja1018 @junghwan-park
@jinwoo-kim-nhn @jungeun-cho
refactor: monorepo skeleton (#523)
0d21d3c 
* chore: make apps directory, move files to apps

* chore: fix test cases, misspellings and change NHN Ent to NHN

* chore: fix range tool options type

* feat: monorepo (#524)

* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>
lja1018 added a commit that referenced this pull request Feb 22, 2021
@lja1018 @junghwan-park
@jinwoo-kim-nhn @jungeun-cho
feat: v3.12.0 (#529)
de4d7ac 
* refactor: monorepo skeleton (#523)

* chore: make apps directory, move files to apps

* chore: fix test cases, misspellings and change NHN Ent to NHN

* chore: fix range tool options type

* feat: monorepo (#524)

* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

* fix: not work filter in direct api example [#388] (#525)

* fix: classname error when clicking in the gap [#411] (#526)

* fix: not occur text changed event [#387, #419] (#527)

* fix: disappear image when apply crop [#359] (#528)

* env: fix editorconfig tabsize

* fix: image disappears when applying an empty cropzone (#359)

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junghwan-park junghwan-park junghwan-park left review comments

@dongsik-yoo dongsik-yoo dongsik-yoo left review comments

@jung-han jung-han jung-han left review comments

@seonim-ryu seonim-ryu seonim-ryu approved these changes

@jinwoo-kim-nhn jinwoo-kim-nhn jinwoo-kim-nhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lja1018 @junghwan-park @seonim-ryu @dongsik-yoo @jinwoo-kim-nhn @jung-han @jungeun-cho