Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Cropping Before Crop Area Is Placed #359

Closed
bulentAkgul opened this issue Mar 9, 2020 · 2 comments
Closed

Prevent Cropping Before Crop Area Is Placed #359

bulentAkgul opened this issue Mar 9, 2020 · 2 comments
Labels
Enhancement Enhance performance or improve usability of original features.

Comments

@bulentAkgul
Copy link

If you hit Apply button whiteout cropping, all image is cropped out. It's normal behavior since all image is dark at that time but it would be nice if doesn't do anything if cropping area is 100% of real image.
@jinwoo-kim-nhn jinwoo-kim-nhn added the Enhancement Enhance performance or improve usability of original features. label Mar 20, 2020
@jinwoo-kim-nhn
Copy link
Contributor

Thanks for the good comments.

lja1018 added a commit that referenced this issue Dec 9, 2020
@lja1018
fix: image disappears when applying an empty cropzone (#359)
b396cb8
lja1018 added a commit that referenced this issue Feb 22, 2021
@lja1018
fix: disappear image when apply crop [#359] (#528)
dde10f6 
* env: fix editorconfig tabsize

* fix: image disappears when applying an empty cropzone (#359)
lja1018 added a commit that referenced this issue Feb 22, 2021
@lja1018 @junghwan-park
@jinwoo-kim-nhn @jungeun-cho
feat: v3.12.0 (#529)
de4d7ac 
* refactor: monorepo skeleton (#523)

* chore: make apps directory, move files to apps

* chore: fix test cases, misspellings and change NHN Ent to NHN

* chore: fix range tool options type

* feat: monorepo (#524)

* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>

* fix: not work filter in direct api example [#388] (#525)

* fix: classname error when clicking in the gap [#411] (#526)

* fix: not occur text changed event [#387, #419] (#527)

* fix: disappear image when apply crop [#359] (#528)

* env: fix editorconfig tabsize

* fix: image disappears when applying an empty cropzone (#359)

Co-authored-by: junghwan-park <junghwan.park@nhnent.com>
Co-authored-by: jung-han <hanjung@nhnent.com>
Co-authored-by: 김진우 <jw.kim@nhnent.com>
Co-authored-by: jungeun-cho <jenny.cho@nhnent.com>
Co-authored-by: jjo Cho <jodeng110@gmail.com>
Co-authored-by: 유동식 <dongsik.yoo@nhnent.com>
Co-authored-by: 박정환 <junghwan-park@users.noreply.github.com>
@lja1018
Copy link
Contributor

lja1018 commented Mar 10, 2021

@bulentAkgul
Thanks for the report. Resolved in v3.12.0.

@lja1018 lja1018 closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Enhance performance or improve usability of original features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bulentAkgul @lja1018 @jinwoo-kim-nhn