Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No scaling value of icon #74

Closed
OculusMode opened this issue Oct 17, 2018 · 2 comments
Closed

No scaling value of icon #74

OculusMode opened this issue Oct 17, 2018 · 2 comments
Labels
Enhancement Enhance performance or improve usability of original features.

Comments

@OculusMode
Copy link

When i scale an icon, i can't get how much big it is.!
the height and width doesn't change and there is no scaling factor to get the height and width.

And how can i manually change height and width of icon?
Changing width and height only changes the outer box not actual icon

Version

Any

Development Environment

Any

Current Behavior

No Scale value for icon(or updated hight or width)

Expected Behavior

give scale value when scalling.

@jinwoo-kim-nhn
Copy link
Contributor

Not yet functional. Sorry.

@jinwoo-kim-nhn jinwoo-kim-nhn added the Enhancement Enhance performance or improve usability of original features. label Dec 27, 2018
lja1018 added a commit that referenced this issue Dec 8, 2020
* feat: add drawingmode for icon - prototyping complete

* feat: complete add drawing mode for icon

* chore: fix misspelling

* chore: apply code review

* fix: icon selection scale

Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>
@lja1018 lja1018 mentioned this issue Dec 8, 2020
7 tasks
lja1018 added a commit that referenced this issue Dec 8, 2020
* feat: add undo stack of object resize/move [#358] (#490)

* feat: add objectModified handler

* feat: resize move add undo stack - middle commit

* feat: resize move add undo stack - middle commit 2

* feat: one item undo redo prototype complate

* feat: undo chage from group selection = #1

* feat: prototyping complete

* feat: add selectionModifyHelper

* feat: complate refactoring

* refactor: complete refactoring

* feat: added test for changeSelection command

* test: add selectionModifyHelper test

* chore: fix misspelling

* chore: apply code review

Co-authored-by: lja1018 <jaeeon.lim@nhn.com>
Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* feat: update fabric version to 4.2.0 [#461] (#491)

* feat: fabricjs version update 3.6.0 -> 4.2.0 - start prototyping

* feat: apply fabric v4.2.0 breaking changes

* test: fix fabric v4.2.0 breaking changes

* chore: change example cdn link

* fix: icon event drag error bug at IE

* env: update fabric version to 4.2.0

* chore: change misspelling

* chore: fix misspelling

* chore: apply code review

Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* feat: add icon drawing mode [#74, #441] (#492)

* feat: add drawingmode for icon - prototyping complete

* feat: complete add drawing mode for icon

* chore: fix misspelling

* chore: apply code review

* fix: icon selection scale

Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* fix: text line-through decoration (#496)

* fix: not apply setBrush API when LINE_DRAWING (#497)

* feat: apply prettier (#493)

* env: add prettier

* chore: apply prettier

Co-authored-by: 김진우 <35218826+jinwoo-kim-nhn@users.noreply.github.com>
Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>
@lja1018
Copy link
Contributor

lja1018 commented Dec 9, 2020

@OculusMode
This issue was resolved in v3.11.0. Thank you!

@lja1018 lja1018 closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features.
Projects
None yet
Development

No branches or pull requests

3 participants