Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo-redo function converts Icon to small size #441

Closed
jmenguito opened this issue Aug 25, 2020 · 3 comments
Closed

Undo-redo function converts Icon to small size #441

jmenguito opened this issue Aug 25, 2020 · 3 comments
Labels
Bug

Comments

@jmenguito
Copy link

Version
3.9.0

Describe the bug
Drawing Icon converts to small size after undo and redo is performed.

To Reproduce
Steps to reproduce the behavior:

  1. Click on 'Icon'
  2. Draw any shape
  3. Click on 'undo', then 'redo'
  4. After 'redo', the shape becomes small in size
@jmenguito jmenguito added the Bug label Aug 25, 2020
@jinwoo-kim-nhn
Copy link
Contributor

@jmenguito Thanks for letting me know, I'll fix it.

@lja1018 lja1018 mentioned this issue Dec 4, 2020
Merged
7 tasks
lja1018 added a commit that referenced this issue Dec 8, 2020
@lja1018
feat: add icon drawing mode [#74, #441] (#492)
4e53b7e 
* feat: add drawingmode for icon - prototyping complete

* feat: complete add drawing mode for icon

* chore: fix misspelling

* chore: apply code review

* fix: icon selection scale

Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>
@lja1018 lja1018 mentioned this issue Dec 8, 2020
Merged
7 tasks
lja1018 added a commit that referenced this issue Dec 8, 2020
@lja1018 @jinwoo-kim-nhn
feat: v3.11.0 (#498)
96e47c7 
* feat: add undo stack of object resize/move [#358] (#490)

* feat: add objectModified handler

* feat: resize move add undo stack - middle commit

* feat: resize move add undo stack - middle commit 2

* feat: one item undo redo prototype complate

* feat: undo chage from group selection = #1

* feat: prototyping complete

* feat: add selectionModifyHelper

* feat: complate refactoring

* refactor: complete refactoring

* feat: added test for changeSelection command

* test: add selectionModifyHelper test

* chore: fix misspelling

* chore: apply code review

Co-authored-by: lja1018 <jaeeon.lim@nhn.com>
Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* feat: update fabric version to 4.2.0 [#461] (#491)

* feat: fabricjs version update 3.6.0 -> 4.2.0 - start prototyping

* feat: apply fabric v4.2.0 breaking changes

* test: fix fabric v4.2.0 breaking changes

* chore: change example cdn link

* fix: icon event drag error bug at IE

* env: update fabric version to 4.2.0

* chore: change misspelling

* chore: fix misspelling

* chore: apply code review

Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* feat: add icon drawing mode [#74, #441] (#492)

* feat: add drawingmode for icon - prototyping complete

* feat: complete add drawing mode for icon

* chore: fix misspelling

* chore: apply code review

* fix: icon selection scale

Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* fix: text line-through decoration (#496)

* fix: not apply setBrush API when LINE_DRAWING (#497)

* feat: apply prettier (#493)

* env: add prettier

* chore: apply prettier

Co-authored-by: 김진우 <35218826+jinwoo-kim-nhn@users.noreply.github.com>
Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>
@lja1018
Copy link
Contributor

lja1018 commented Dec 9, 2020

@jmenguito
This issue was resolved in v3.11.0. Thank you!

@lja1018 lja1018 closed this as completed Dec 9, 2020
@jmenguito
Copy link
Author

Wow! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lja1018 @jmenguito @jinwoo-kim-nhn