feat: add icon drawing mode [#74, #441] #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/js/action.js
lja1018
added a commit
that referenced
this pull request
Dec 8, 2020
* feat: add undo stack of object resize/move [#358] (#490) * feat: add objectModified handler * feat: resize move add undo stack - middle commit * feat: resize move add undo stack - middle commit 2 * feat: one item undo redo prototype complate * feat: undo chage from group selection = #1 * feat: prototyping complete * feat: add selectionModifyHelper * feat: complate refactoring * refactor: complete refactoring * feat: added test for changeSelection command * test: add selectionModifyHelper test * chore: fix misspelling * chore: apply code review Co-authored-by: lja1018 <jaeeon.lim@nhn.com> Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com> * feat: update fabric version to 4.2.0 [#461] (#491) * feat: fabricjs version update 3.6.0 -> 4.2.0 - start prototyping * feat: apply fabric v4.2.0 breaking changes * test: fix fabric v4.2.0 breaking changes * chore: change example cdn link * fix: icon event drag error bug at IE * env: update fabric version to 4.2.0 * chore: change misspelling * chore: fix misspelling * chore: apply code review Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com> * feat: add icon drawing mode [#74, #441] (#492) * feat: add drawingmode for icon - prototyping complete * feat: complete add drawing mode for icon * chore: fix misspelling * chore: apply code review * fix: icon selection scale Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com> * fix: text line-through decoration (#496) * fix: not apply setBrush API when LINE_DRAWING (#497) * feat: apply prettier (#493) * env: add prettier * chore: apply prettier Co-authored-by: 김진우 <35218826+jinwoo-kim-nhn@users.noreply.github.com> Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
By adding the icon drawing mode, the size of the icon is properly reflected when undo/redo the icon.
So, issues #74 , #441 have been resolved.
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨