Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update fabric version to 4.2.0 [#461] #491

Merged
merged 9 commits into from
Dec 8, 2020

Conversation

lja1018
Copy link
Contributor

@lja1018 lja1018 commented Dec 4, 2020

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

작업내역


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@lja1018 lja1018 mentioned this pull request Dec 4, 2020
7 tasks
Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[12/04] 리뷰 완료합니다. 고생하셨습니다.
메이저 업데이트인데 다행히 생각보다 코드 변경 사항은 적네요.

  • 메이저 업데이트에서 우리 이미지 에디터에서 수용할만한 개선점은 있나요?

README.md Outdated Show resolved Hide resolved
examples/example01-includeUi.html Show resolved Hide resolved
src/js/component/shape.js Show resolved Hide resolved
src/js/graphics.js Show resolved Hide resolved
@lja1018
Copy link
Contributor Author

lja1018 commented Dec 8, 2020

[12/04] 리뷰 완료합니다. 고생하셨습니다.
메이저 업데이트인데 다행히 생각보다 코드 변경 사항은 적네요.

  • 메이저 업데이트에서 우리 이미지 에디터에서 수용할만한 개선점은 있나요?

breaking change가 전부 특정 옵션의 변경, 제거와 사용방법 변경이라서 작업이 금방 끝났습니다

@lja1018 lja1018 merged commit 792dfb1 into feat/v3.11.0 Dec 8, 2020
@lja1018 lja1018 deleted the feat/fabricUpdate4.2.0 branch December 8, 2020 02:57
lja1018 added a commit that referenced this pull request Dec 8, 2020
* feat: add undo stack of object resize/move [#358] (#490)

* feat: add objectModified handler

* feat: resize move add undo stack - middle commit

* feat: resize move add undo stack - middle commit 2

* feat: one item undo redo prototype complate

* feat: undo chage from group selection = #1

* feat: prototyping complete

* feat: add selectionModifyHelper

* feat: complate refactoring

* refactor: complete refactoring

* feat: added test for changeSelection command

* test: add selectionModifyHelper test

* chore: fix misspelling

* chore: apply code review

Co-authored-by: lja1018 <jaeeon.lim@nhn.com>
Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* feat: update fabric version to 4.2.0 [#461] (#491)

* feat: fabricjs version update 3.6.0 -> 4.2.0 - start prototyping

* feat: apply fabric v4.2.0 breaking changes

* test: fix fabric v4.2.0 breaking changes

* chore: change example cdn link

* fix: icon event drag error bug at IE

* env: update fabric version to 4.2.0

* chore: change misspelling

* chore: fix misspelling

* chore: apply code review

Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* feat: add icon drawing mode [#74, #441] (#492)

* feat: add drawingmode for icon - prototyping complete

* feat: complete add drawing mode for icon

* chore: fix misspelling

* chore: apply code review

* fix: icon selection scale

Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>

* fix: text line-through decoration (#496)

* fix: not apply setBrush API when LINE_DRAWING (#497)

* feat: apply prettier (#493)

* env: add prettier

* chore: apply prettier

Co-authored-by: 김진우 <35218826+jinwoo-kim-nhn@users.noreply.github.com>
Co-authored-by: jinwoo-kim-nhn <jw.kim@nhn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants