Feature/register npm #1
Conversation
| "karma-sourcemap-loader": "^0.3.7", | ||
| "karma-webdriver-launcher": "git+https://github.com/everedifice/karma-webdriver-launcher.git", | ||
| "karma-webdriver-launcher": "git+https://github.com/nhnent/karma-webdriver-launcher.git", |
There was a problem hiding this comment.
버전명 명시해야겠네요~
"karma-webdriver-launcher": "git+https://github.com/nhnent/karma-webdriver-launcher.git#v1.1.0"
| 'IE10', | ||
| 'IE11', | ||
| 'Edge', | ||
| 'Chrome-WebDriver' |
There was a problem hiding this comment.
여기두 웹 드라이버 설정이 빠졌네용~
그리고 IE 버전 스트링으로 감싸는 것두요~
'Safari-WebDriver': {
base: 'WebDriver',
config: webdriverConfig,
browserName: 'safari'
}
'Firefox-WebDriver'
// 'Safari-WebDriver' // active only when safari test is needed
There was a problem hiding this comment.
저번에 사파리 웹드라이브 문제있다고 해서 제외한거였는데. 이제 이슈 없으니 다시 넣어야겟네요ㅎ
| "NHNent. FE Development Lab <dl_javascript@nhnent.com>" | ||
| ], | ||
| "main": [ | ||
| "dist/tui-project-name.js" |
| "package.json" | ||
| ], | ||
| "dependencies": { | ||
| "tui-code-snippet": "~1.2.5" |
There was a problem hiding this comment.
근데 생각해보면.. bower 버전이 애매하군뇨
There was a problem hiding this comment.
큽... 무슨 말인지 모르겠.. 공부를.. 해야...겠네용
| "tui": true, | ||
| "loadFixtures": true | ||
| } | ||
| }; |
There was a problem hiding this comment.
이 파일은 없어도 되겠네요~
https://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy
When ESLint traverses into the tests/ directory, it will then use your-project/tests/.eslintrc in addition to your-project/.eslintrc. So your-project/tests/test.js is linted based on the combination of the two.
프로젝트 루트에 있는 .eslintrc랑 내용이 같아서 필요없어보이네요~
max-nested-callbacks처럼 test 파일들에만 적용할 룰들을 추가할 때만 필요하겠네용 ;ㅅ;
module.exports = {
"rules": {
"max-nested-callbacks": 0
}
};
There was a problem hiding this comment.
테스트하다가 파일 삭제 안된채로 올라갔나보네요 ㅠㅠ 감사요~~ 저 파일은 필요없어요ㅎ
No description provided.