Simplify unit::toLinearized
#193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, removing the template would be more idiomatic. |
Am I correct to assume that you agree with the "further simplification" as posted in the second part of the OP? I'm asking because I was going to implement that. The commit for (manually) closing this PR looks wrong and doesn't include a part of the changes, presumably due to the conflicts (for having added |
|
yes agree to the second part. go ahead and deconflict as much as you can,
especially #150.
…On Fri, Oct 26, 2018 at 2:41 PM Johel Ernesto Guerrero Peña < ***@***.***> wrote:
yeah, removing the template would be more idiomatic.
Am I correct to assume that you agree with the "further simplification" as
posted in the second part of the OP? I'm asking because I was going to
implement that.
The commit for (manually) closing this PR looks wrong and doesn't include
a part of the changes, presumably due to the conflicts (for having added
linearized_value).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#193 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJ2HH9FxjIcuQTefAdbxftQ32br3ekp2ks5uo1dygaJpZM4XMG-H>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defaulting
units::toLinearized's return type to the unit'sunderlying_type, call sites that don't need something else get simpler.What do you think about simplifying it further, so that it's not a template function? Changing
x.template toLinearized<Arithmetic>()forstatic_cast<Arithmetic>(x.toLinearized())is, I believe, more clear on the intention and easier to read at call site.