fix nonce validation #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `payload` argument passed to #verify_nonce! comes directly from JWT.decode which responds with a hash using string keys and not symbols. Other uses of `id_info` all correctly use string keys. Without this change, the #verify_nonce! method always handles the payload as if 'nonce_supported' is falsy.
nhosoya
approved these changes
Jun 18, 2020
nhosoya
reviewed
Jun 18, 2020
| @@ -76,13 +76,13 @@ def id_info | |||
| def fetch_jwks | |||
| uri = URI.parse('https://appleid.apple.com/auth/keys') | |||
| response = Net::HTTP.get_response(uri) | |||
| { keys: JSON.parse(response.body)['keys'].map { |key| deep_symbolize(key) } } | |||
| JSON.parse(response.body, symbolize_names: true) | |||
There was a problem hiding this comment.
It's simple and very good implementation.
yamarkz
reviewed
Jul 22, 2020
|
|
||
| return if payload[:nonce].present? && payload[:nonce] != stored_nonce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
payloadargument passed to #verify_nonce! comes directly from JWT.decode which responds with a hash using string keys and not symbols. Other uses ofid_infoall correctly use string keys.Without this change, the #verify_nonce! method always handles the payload as if 'nonce_supported' is falsy.