handle JWKS fetch failures #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nov
force-pushed
the
feature/better_error_handling
branch
2 times, most recently
from
a05710f
to
34c98da
Compare
nhosoya
reviewed
Oct 25, 2022
Comment on lines
+90
to
+91
| else | ||
| {} |
There was a problem hiding this comment.
What situation is this supposed to be?
There was a problem hiding this comment.
even calling fail!, id_info['sub'] is called in info do ... end block.
so returning nil results in NoMethodError: undefined method '[]' for nil:NilClass
nhosoya
approved these changes
Oct 25, 2022
which often results in 502 bad gateway
nov
force-pushed
the
feature/better_error_handling
branch
from
34c98da
to
c64bbf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which often results in 502 bad gateway