Add Card component #627
Merged
Add Card component #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhunter08
force-pushed
the
feature/card-component
branch
from
b911f29
to
0e17bb7
Compare
davidhunter08
force-pushed
the
feature/card-component
branch
3 times, most recently
from
a06e8a4
to
536e6a5
Compare
chrimesdev
approved these changes
Sep 25, 2020
davidhunter08
force-pushed
the
feature/card-component
branch
from
174e0a0
to
5eff224
Compare
This was
linked to
issues
Sep 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add new card component to supersede the existing promo and panel components.
Why
The panel and promo were two components in the NHS.UK frontend that did not have guidance in the service manual. They both also shared a lot of the same structure and design. This confused users of the design system, with people not knowing when and how to use the components.
There was also an accessibility issue with the content of the promo component being all contained within a link (anchor tag) causing a difficult experience for screenreader users. We have fixed this issue and combined the two components into one new (card) component.
Further detail
Variants include:
Basic card
Clickable card
For cards that contain a single link, the hit area for that link can be made to wrap the entire card.
We avoid wrapping an entire card in an anchor tag as this can be a difficult experience for a screen reader user.
Card with an image
Card group
Feature card
Checklist