-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/remove current page breadcrumb #872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - seems like a nice cleanup.
Could we maybe do it in a backward compatible way? Leave the old params in and use them if they're present. Otherwise use the new way. Change the docs to encourage the new way, but allow the old way for a while, until we actually do another major release. It just feels like such a small change to push out a whole major version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Probably worth looking into what Andy said about backward compatibilities.
LGTM. Nice work @the-nathan-smith |
Description
Removed the need to add the last breadcrumb outside of the 'Items' list, now simply include it in the list of items. This also fixes the issue (Issue 471 in the nhsuk Service Manual) with not being able to add attributes to the last breadcrumb.
Checklist