You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that when these clusters contain "void", grpc-labview refrains from scripting a connecting wire between the unbundle & bundle nodes. Being that it's "void", this scripted implementation is seemingly technically adequate (due to there being no data to pass through for the void case). But at a glance it appears broken, and I've discovered that VI Analyzer flags such cases with a level-2 (high-severity) "Unused code" issue, ala:
FlatToRichni_measurementlink_discovery_v1_UnregisterServiceResponse.vi (C:\github\measurementlink-labview\Source\Runtime\MeasurementLink Discovery Client\RPC Messages\FlatToRichni_measurementlink_discovery_v1_UnregisterServiceResponse.vi)
Unused Code The function "Unbundle" has none of its outputs wired, and therefore performs no useful operation. Consider removing this function from your diagram.
Are these adapter VIs even needed for the void case? If so, perhaps the VI could be scripted in such way to not contain unused code.
AB#2605671
The text was updated successfully, but these errors were encountered:
aepete
added a commit
to ni/measurement-plugin-labview
that referenced
this issue
Dec 15, 2023
The code appears as follows:
It seems that when these clusters contain "void", grpc-labview refrains from scripting a connecting wire between the unbundle & bundle nodes. Being that it's "void", this scripted implementation is seemingly technically adequate (due to there being no data to pass through for the void case). But at a glance it appears broken, and I've discovered that VI Analyzer flags such cases with a level-2 (high-severity) "Unused code" issue, ala:
Are these adapter VIs even needed for the void case? If so, perhaps the VI could be scripted in such way to not contain unused code.
AB#2605671
The text was updated successfully, but these errors were encountered: