Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RictToFlat* & FlatToRich* scripted VIs drop unused unbundle & bundle when operating on cluster of "void" #333

Open
aepete opened this issue Dec 15, 2023 · 0 comments

Comments

@aepete
Copy link

aepete commented Dec 15, 2023

The code appears as follows:
image

It seems that when these clusters contain "void", grpc-labview refrains from scripting a connecting wire between the unbundle & bundle nodes. Being that it's "void", this scripted implementation is seemingly technically adequate (due to there being no data to pass through for the void case). But at a glance it appears broken, and I've discovered that VI Analyzer flags such cases with a level-2 (high-severity) "Unused code" issue, ala:

FlatToRichni_measurementlink_discovery_v1_UnregisterServiceResponse.vi (C:\github\measurementlink-labview\Source\Runtime\MeasurementLink Discovery Client\RPC Messages\FlatToRichni_measurementlink_discovery_v1_UnregisterServiceResponse.vi)
Unused Code     The function "Unbundle" has none of its outputs wired, and therefore performs no useful operation.  Consider removing this function from your diagram.

Are these adapter VIs even needed for the void case? If so, perhaps the VI could be scripted in such way to not contain unused code.

AB#2605671

aepete added a commit to ni/measurement-plugin-labview that referenced this issue Dec 15, 2023
aepete added a commit to ni/measurement-plugin-labview that referenced this issue Dec 15, 2023
* Enable Unused Code check in VI Analyzer

* Add handful of `Unused Code` exclusions, a workaround for ni/grpc-labview#333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant