Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for unpacking varints in unknownfields. #369

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Added support for unpacking varints in unknownfields. #369

merged 2 commits into from
Jul 26, 2024

Conversation

yash-ni
Copy link
Collaborator

@yash-ni yash-ni commented Jul 18, 2024 •
edited
Loading

Fix for #366

Changes:

  • Implemented unpacking for all varint types (int32, int64, uint32, uint64, sint32, sint64, enum)

@yash-ni yash-ni requested a review from ni-sujain July 18, 2024 09:09
ni-sujain
ni-sujain approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@ni-sujain ni-sujain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can mention that we don't support all types of unknown field parsing. This may fix the specific issue but cannot guarantee to work for all cases. If we want extensive support for unknown types, then it should be new feature request

@yash-ni yash-ni merged commit f6ef366 into ni:master Jul 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ni-sujain ni-sujain ni-sujain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-ni @ni-sujain