Add attributes used by SystemLinkShared that shouldn't trigger template/i18n #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
approved these changes
May 17, 2024
jattasNI
added a commit
that referenced
this pull request
May 17, 2024
) Same as #143 but one more attribute that I didn't discover until after polishing [the SystemLink PR uptaking this rule change](https://dev.azure.com/ni/DevCentral/_git/Skyline/pullrequest/716904)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #140, our original list of attributes was incomplete. I'm adding the attributes that are needed to build Skyline
Web/Workspaces/SystemLinkShared.Here's the SLE PR that is blocked on this