Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printk: nbcon: move locked_port flag to struct uart_port #147

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

gratian
Copy link
Contributor

@gratian gratian commented Feb 26, 2024

Console pointer in uart_port might be shared among multiple uart ports. Flag port locked by nbcon should be saved in uart_port structure instead of in console structure.

Fixes: 6424f396c49e ("printk: nbcon: Implement processing in port->lock wrapper")
Suggested-by: John Ogness john.ogness@linutronix.de
Signed-off-by: Junxiao Chang junxiao.chang@intel.com
Signed-off-by: Sebastian Andrzej Siewior bigeasy@linutronix.de
Link: https://lore.kernel.org/all/20240123054033.183114-2-junxiao.chang@intel.com
(cherry picked from commit d4fb86a96cb4a1efd24ca13a2ac234a1c9a3fdc5)
Signed-off-by: Gratian Crisan gratian.crisan@ni.com

Console pointer in uart_port might be shared among multiple uart
ports. Flag port locked by nbcon should be saved in uart_port
structure instead of in console structure.

Fixes: 6424f396c49e ("printk: nbcon: Implement processing in port->lock wrapper")
Suggested-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Junxiao Chang <junxiao.chang@intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/all/20240123054033.183114-2-junxiao.chang@intel.com
(cherry picked from commit d4fb86a96cb4a1efd24ca13a2ac234a1c9a3fdc5)
Signed-off-by: Gratian Crisan <gratian.crisan@ni.com>
@gratian gratian requested a review from a team February 26, 2024 20:10
@gratian
Copy link
Contributor Author

gratian commented Feb 26, 2024

Fixes

Testing

  • manually re-built kernel
  • installed on target and re-versioned NI modules via dkms autoinstall
  • validated it fixes the kernel panic observed in AB#2646784

@gratian gratian merged commit 392c78a into ni:nilrt/master/6.6 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants