Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio group error #2423

Merged
merged 13 commits into from
Oct 9, 2024
Merged

Radio group error #2423

merged 13 commits into from
Oct 9, 2024

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

Includes nimble-component implementation for #2019

👩‍💻 Implementation

  • Adds error-visible and error-text attributes to the nimble-radio-group
  • Updates the radio group template to include an error icon and error text
    • Note: This required forking FAST's template
  • Updated radio group styling to match visual design

🧪 Testing

  • Manually tested in storybook
  • Forked FAST's radio group tests since the template was forked
  • Updated matrix tests

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@m-akinc, will you buddy this PR for me?

@mollykreis mollykreis marked this pull request as ready for review October 4, 2024 17:44
@mollykreis mollykreis merged commit 8aa7c1e into main Oct 9, 2024
14 checks passed
@mollykreis mollykreis deleted the radio-group-error branch October 9, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jattasNI jattasNI jattasNI approved these changes

@m-akinc m-akinc m-akinc approved these changes

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mollykreis @rajsite @m-akinc @jattasNI