Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests aren't re-run if they fail in next make #124

Closed
marcoskirsch opened this issue Aug 12, 2017 · 1 comment
Closed

Unit tests aren't re-run if they fail in next make #124

marcoskirsch opened this issue Aug 12, 2017 · 1 comment
Assignees

Comments

@marcoskirsch
Copy link
Member

Say you run

make

...and the unit tests fail.

Then next time you run

make

the unit tests won't be re-run and the build will complete successfully.

This is probably because the make rule uses file test_results.log alone as a target in order to determine if it needs to execute.

@marcoskirsch
Copy link
Member Author

After I make clean:

  1. On first make nidmm unit tests fail, build stops.
  2. On second make nimodinst unit tests fail, build stops.
  3. On third make, "success"!
Kirsch0:nimi-python kirsch$ make
make[1]: Nothing to be done for `MKDIR'.
Creating nidmm enums.py
Creating nidmm library.py
Creating nidmm session.py
Creating nidmm errors.py
Creating nidmm ctypes_library.py
Creating nidmm mock_helper.py
Creating nidmm __init__.py
Creating nidmm ctypes_types.py
Creating nidmm python_types.py
Creating nidmm session.rst
Creating nidmm enums.rst
Creating nidmm attributes.rst
Creating nidmm test_session.py
Creating nidmm setup.py
Updating generated files for nidmm
Creating nidmm README.rst
Running unit tests for nidmm
make[1]: *** [/Users/kirsch/Developer/nimi-python/bin/nidmm/log/test_results.log] Error 1
make: *** [nidmm] Error 2
Kirsch0:nimi-python kirsch$ make
make[1]: Nothing to be done for `MKDIR'.
Updating generated files for nidmm
Creating Wheel distribution for nidmm
zip_safe flag not set; analyzing archive contents...
Creating Source distribution for nidmm
Creating nimodinst library.py
Creating nimodinst session.py
Creating nimodinst errors.py
Creating nimodinst ctypes_library.py
Creating nimodinst mock_helper.py
Creating nimodinst __init__.py
Creating nimodinst ctypes_types.py
Creating nimodinst python_types.py
Creating nimodinst session.rst
Creating nimodinst attributes.rst
Creating nimodinst test_modinst.py
Creating nimodinst setup.py
Updating generated files for nimodinst
Creating nimodinst README.rst
Running unit tests for nimodinst
make[1]: *** [/Users/kirsch/Developer/nimi-python/bin/nimodinst/log/test_results.log] Error 2
make: *** [nimodinst] Error 2
Kirsch0:nimi-python kirsch$ make
make[1]: Nothing to be done for `MKDIR'.
Updating generated files for nidmm
Creating Wheel distribution for nidmm
Creating Source distribution for nidmm
make[1]: Nothing to be done for `MKDIR'.
Updating generated files for nimodinst
Creating Wheel distribution for nimodinst
zip_safe flag not set; analyzing archive contents...
Creating Source distribution for nimodinst
Kirsch0:nimi-python kirsch$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants