Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the unit tests every time #133

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Run the unit tests every time #133

merged 1 commit into from
Aug 17, 2017

Conversation

texasaggie97-zz
Copy link
Contributor

[X] This contribution adheres to [CONTRIBUTING.md]

What does this Pull Request accomplish?

Why should this Pull Request be merged?

  • Fixes issue

What testing has been done?

  • Travis
  • Building multiple time under different circumstances

This is not invoking tox, just run a quick pytest on the generated files
Copy link
Member

@marcoskirsch marcoskirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this fixed the issue, but introduces a new issue (tests run when not necessary).
The new issue is more benign than the original.

Do you want to merge this and we open a new issue, or do you want to try and get it to work right?

@texasaggie97-zz
Copy link
Contributor Author

I prefer to merge this and start another issue about building too much. Wheels also build every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants