Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 support and drop Python 3.6 support #1810

Merged
merged 7 commits into from
Sep 1, 2022

Conversation

sbethur
Copy link
Contributor

@sbethur sbethur commented Aug 23, 2022

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Add support for Python 3.10
  • Drop support for Python 3.6

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR build

@sbethur
Copy link
Contributor Author

sbethur commented Aug 23, 2022

The system tests will fail until internal PR 344267 is submitted.

.travis.yml Outdated Show resolved Hide resolved
Co-authored-by: Marcos <marcoskirsch@users.noreply.github.com>
.travis.yml Outdated Show resolved Hide resolved
@sbethur
Copy link
Contributor Author

sbethur commented Aug 23, 2022

The system tests will fail until internal PR 344267 is submitted.

Well, the system tests on 3.10 got skipped rather than the PR build pipeline failing. Guess that's ok.

@sbethur sbethur closed this Aug 23, 2022
@sbethur sbethur reopened this Aug 23, 2022
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@sbethur
Copy link
Contributor Author

sbethur commented Aug 26, 2022

The system tests will fail until internal PR 344267 is submitted.

Well, the system tests on 3.10 got skipped rather than the PR build pipeline failing. Guess that's ok.

The internal PR was submitted and the updated nimibot VM has been deployed. @marcoskirsch / @ni-jfitzger , this PR is ready for merge.

@ni-jfitzger
Copy link
Collaborator

The win_32 run failed on setting up for python 3.10 testing, but succeeded on all other Python versions in a previous run. RHEL and win_64 nimibot runs succeeded on all Python versions.

The win_32 failure appears to be a failure to install scipy due to No win32 wheel for Python 3.10.

@marcoskirsch
Copy link
Member

Created #1811

@marcoskirsch
Copy link
Member

@sbethur #1817 is merged (thanks @ni-jfitzger !).
Merge that and try again.

@sbethur
Copy link
Contributor Author

sbethur commented Sep 1, 2022

@sbethur #1817 is merged (thanks @ni-jfitzger !). Merge that and try again.

Done. The PR build is running.

@ni-jfitzger ni-jfitzger merged commit f3324c7 into ni:master Sep 1, 2022
@sbethur sbethur deleted the update_python_versions branch September 1, 2022 16:22
@ni-jfitzger ni-jfitzger mentioned this pull request Jul 11, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants