Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple issues #97

Closed
wants to merge 8 commits into from
Closed

Fix multiple issues #97

wants to merge 8 commits into from

Conversation

texasaggie97-zz
Copy link
Contributor

@texasaggie97-zz texasaggie97-zz commented Jul 27, 2017 •
edited
Loading

[X] This contribution adheres to [CONTRIBUTING.md]

What does this Pull Request accomplish?

  • Fixes 96
    • Add FrozenClass and inherit from that
    • Add test
  • Fixes 95
    • Remove ViSession as a supported attribute type
    • Remove ViSession test
  • Fixes 91
    • Add driver name to each print
  • Fixes 90
    • Add author_email, url and zip_safe to setup.py.mako
    • Still getting statement about zip_safe flag not set; analyzing archive contents... even though that is explicitly set
    • Supress output from clean when file(s) don't exist

Why should this Pull Request be merged?

  • Cleans up issues

What testing has been done?

  • Travis & system test

@marcoskirsch
Copy link
Member

Is it reasonable to split this PR in 4 ?

@texasaggie97-zz
Copy link
Contributor Author

Yes, but each change is so small, that seems like over kill.

@texasaggie97-zz texasaggie97-zz deleted the build/fix_system_test branch July 28, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@texasaggie97-zz @marcoskirsch @texasaggie97