Add camelCase util function and use in test-helpers #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added a couple of items to .gitignore for my own dev environment |
ediblecode
suggested changes
Jan 29, 2018
test/unit/utils.test.js
Outdated
| @@ -74,4 +74,14 @@ describe("Utils", function() { | |||
|
|
|||
| }); | |||
|
|
|||
| describe('jQuery camelCase (private method)', () => { | |||
There was a problem hiding this comment.
These quotes should use " to pass linting rules
test/test-helpers.js
Outdated
| @@ -21,7 +21,7 @@ const { JSDOM } = jsdom; | |||
| */ | |||
| function renderComponent(name, data) { | |||
| var template = fs.readFileSync(path.join(__dirname, `../src/components/${ name }/${ name }.njk`), "utf8"); | |||
| return nunjucks.renderString(`${ template}{{ ${ name }(content) }}"`, { content: data }); | |||
| return nunjucks.renderString(`${ template}{{ ${ $.camelCase(name) }(content) }}"`, { content: data }); | |||
There was a problem hiding this comment.
Can you remove the extra double quotes?
Test helper nunjucks render function presumed that a file's macro would match the file name - replaced with a camelCase template name
ediblecode
approved these changes
Jan 29, 2018
ediblecode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.