encode chapter related ids from str to bytes #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't pull. This was my work around but may offer some insight into a pain point.
But I don't think it solves the underlying issues.
When trying to run
examples/chapters.py
I was hitting errors likeTypeError: can only concatenate str (not "bytes") to str
and the like. I think the real issue is maybe the example is out dated and need to be passing in byte strings instead of strings.or that the
utils/requireBytes
decorator should be applied more thoroughly to theChapterFrame
andTocFrame
constructors.