Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode chapter related ids from str to bytes #550

Open
wants to merge 1 commit into
base: 0.9.x
Choose a base branch
from

Conversation

zvodd
Copy link

@zvodd zvodd commented Aug 8, 2021

Don't pull. This was my work around but may offer some insight into a pain point.
But I don't think it solves the underlying issues.

When trying to run examples/chapters.py I was hitting errors like TypeError: can only concatenate str (not "bytes") to str and the like. I think the real issue is maybe the example is out dated and need to be passing in byte strings instead of strings.
or that the utils/requireBytes decorator should be applied more thoroughly to the ChapterFrame and TocFrame constructors.

@nicfit
Copy link
Owner

nicfit commented Aug 10, 2021

Hi @zvodd , thanks for the patches. Not sure if you checked out the chapters branch but I'd be curious whether the same problems occur there. The changes can be seen in #531 . And any chapter PRs should target that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants