Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make equinox and paradox compile with GHC 7.4.1 #1

Merged
merged 2 commits into from
Apr 19, 2012
Merged

Make equinox and paradox compile with GHC 7.4.1 #1

merged 2 commits into from
Apr 19, 2012

Conversation

danr
Copy link
Contributor

@danr danr commented Apr 19, 2012

A lot of the imports were using the old style, updated to the hierarchy style.

There are still a lot of warnings when compiling, such as using fglasgowexts is deprecated, and this:

Sat.hs:341:1:
Warning: newtype `CInt' is used in an FFI declaration,
but its constructor is not in scope.
This will become an error in GHC 7.6.1.
When checking declaration:
foreign import ccall unsafe "static Wrapper.h solver_lit_begin" solver_lit_begin
:: Solver -> (Ptr ()) -> CInt -> IO ()

/Dan

nick8325 added a commit that referenced this pull request Apr 19, 2012
Make equinox and paradox compile with GHC 7.4.1
@nick8325 nick8325 merged commit e94d1be into nick8325:master Apr 19, 2012
@nick8325
Copy link
Owner

Hooray, thanks!

On 19 April 2012 18:15, Dan Rosén
reply@reply.github.com
wrote:

A lot of the imports were using the old style, updated to the hierarchy style.

There are still a lot of warnings when compiling, such as using fglasgowexts is deprecated, and this:

Sat.hs:341:1:
   Warning: newtype `CInt' is used in an FFI declaration,
            but its constructor is not in scope.
            This will become an error in GHC 7.6.1.
   When checking declaration:
     foreign import ccall unsafe "static Wrapper.h solver_lit_begin" solver_lit_begin
       :: Solver -> (Ptr ()) -> CInt -> IO ()

/Dan

You can merge this Pull Request by running:

 git pull https://github.com/danr/equinox master

Or you can view, comment on it, or merge it online at:

 #1

-- Commit Summary --

  • Make equinox compile with ghc 7.4.1, perhaps not in the most elegant way
  • Make paradox compile with ghc 7.4.1

-- File Changes --

M Haskell/Equinox/ConSat.hs (56)
M Haskell/Equinox/FolSat.hs (64)
M Haskell/Equinox/TermSat.hs (6)
M Haskell/Flags.hs (35)
M Haskell/Main.hs (20)
M Haskell/Output.hs (7)
M Haskell/Paradox/AnalysisTypes.hs (16)
M Haskell/Paradox/Flatten.hs (105)
M Haskell/Paradox/Instantiate.hs (24)
M Haskell/Paradox/Main.hs (36)
M Haskell/Paradox/SolveInstances.hs (50)
M Haskell/ParseProblem.hs (41)
M Haskell/Parsek.hs (42)
M Haskell/Sat.hs (2)

-- Patch Links --

 https://github.com/nick8325/equinox/pull/1.patch
 https://github.com/nick8325/equinox/pull/1.diff


Reply to this email directly or view it on GitHub:
#1

@jessealama
Copy link

Even with the latest equinox repo (I'm using cf20d54), I still get a lot of warnings during the compilation with GHC 7.4.1 on Mac OS X.

$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 7.4.1

For example:

ghc -optl -static -lstdc++ -I../instantiate -I../minisat/current-base ../minisat/current-base/Solver.or ../minisat/current-base/Prop.or ../instantiate/MiniSatWrapper.or ../instantiate/MiniSatInstantiateClause.or -fglasgow-exts -O2 -static -threaded -threaded --make Equinox/Main.hs -o equinox

on the commandline:
    Warning: -fglasgow-exts is deprecated: Use individual extensions instead

Parsek.hs:1:12:
    Warning: -fglasgow-exts is deprecated: Use individual extensions instead

and

[12 of 15] Compiling ParseProblem     ( ParseProblem.hs, ParseProblem.o )

ParseProblem.hs:59:5:
    Warning: In the use of `IO.try'
             (imported from System.IO.Error):
             Deprecated: "Please use the new exceptions variant, Control.Exception.try"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants