Return None for non-UTF-8 tags #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a panic when opening a file which contains non-UTF-8 tags, but still prevents users from accessing them. In the future it might be useful to provide an API giving the raw bytes if the user wants to try guessing it, or maybe even add an (optional) encoding crate dependency for formats which declare their encoding. Fixes nickbrowne#6.
|
Nice one, thanks for doing this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a panic when opening a file which contains non-UTF-8 tags, but still prevents users from accessing them.
In the future it might be useful to provide an API giving the raw bytes if the user wants to try guessing it, or maybe even add an (optional) encoding crate dependency for formats which declare their encoding.
Fixes #6.