Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary computation in reazon--take #15

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

ethan-leba
Copy link
Contributor

@ethan-leba ethan-leba commented Dec 28, 2021

In the case that reazon-run was set to generate 1 value,reazon--take would erroneously generate a second value and discard it.

Hey again!

I may have found a bug -- let me know what you think! If I'm not mistaken, would you mind rolling a 0.4.1 release for this? I think this could improve the performance of my package a fair bit, as I'm using a bunch of (reazon-run 1 ...)s around my codebase.

@nickdrozd
Copy link
Owner

Great catch! I checked The Reasoned Schemer to see if the bug exists there...but no, it's just a problem with this implementation.

By the way, the email for these commits is just your local mbp.lan. Do you want your real email there? I don't care either way.

In the case that `reazon-run` was set to generate 1 value,
`reazon--take` would erroneously generate a second value and discard it.
@ethan-leba
Copy link
Contributor Author

Great catch! I checked The Reasoned Schemer to see if the bug exists there...but no, it's just a problem with this implementation.

I did too, that would've been quite the find!

By the way, the email for these commits is just your local mbp.lan. Do you want your real email there? I don't care either way.

Ah, thanks for pointing that out.

@nickdrozd nickdrozd merged commit c9451f3 into nickdrozd:main Dec 29, 2021
@nickdrozd
Copy link
Owner

0.4.1 is released. Let me know if there are any problems.

@ethan-leba
Copy link
Contributor Author

It looks like the version's at 0.3 in reazon.el still: https://github.com/nickdrozd/reazon/blob/0.4.1/reazon.el#L7

I'm surprised I haven't gotten any errors specifying a min version of 0.4 actually, weird.. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants