Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "total" field to ManyEventSubSubscriptions #134

Merged
merged 1 commit into from
Feb 27, 2022
Merged

Add "total" field to ManyEventSubSubscriptions #134

merged 1 commit into from
Feb 27, 2022

Conversation

zspri
Copy link
Contributor

@zspri zspri commented Feb 25, 2022

This PR adds the total field to the responses for CreateEventSubSubscription and GetEventSubSubscriptions, representing the total number of EventSub subscriptions created by a client.

Docs:

nicklaw5
nicklaw5 approved these changes Feb 27, 2022
View reviewed changes
Copy link
Owner

@nicklaw5 nicklaw5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1896433296

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.451%
Totals Coverage Status
Change from base Build 1631408067: 0.0%
Covered Lines: 1237
Relevant Lines: 1338
💛 - Coveralls

@nicklaw5 nicklaw5 merged commit cdbaddc into nicklaw5:main Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklaw5 nicklaw5 nicklaw5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zspri @coveralls @nicklaw5