Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subscribing/unsubscribing to/from webhook events #22

Merged
merged 2 commits into from
Dec 26, 2018

Conversation

nicklaw5
Copy link
Owner

This adds a new endpoint for subscribing/unsubscribing to Twitch webhook events. It also includes some convenience methods for identifying individual webhook events when received from Twitch.

TODO:

  • Add docs

@nicklaw5 nicklaw5 added the enhancement New feature or request label Dec 26, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 113

  • 88 of 99 (88.89%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 90.985%

Changes Missing Coverage Covered Lines Changed/Added Lines %
webhooks.go 65 69 94.2%
helix.go 23 30 76.67%
Files with Coverage Reduction New Missed Lines %
helix.go 1 90.98%
Totals Coverage Status
Change from base Build 110: -0.2%
Covered Lines: 656
Relevant Lines: 721

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 113

  • 88 of 99 (88.89%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 90.985%

Changes Missing Coverage Covered Lines Changed/Added Lines %
webhooks.go 65 69 94.2%
helix.go 23 30 76.67%
Files with Coverage Reduction New Missed Lines %
helix.go 1 90.98%
Totals Coverage Status
Change from base Build 110: -0.2%
Covered Lines: 656
Relevant Lines: 721

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 113

  • 88 of 99 (88.89%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 90.985%

Changes Missing Coverage Covered Lines Changed/Added Lines %
webhooks.go 65 69 94.2%
helix.go 23 30 76.67%
Files with Coverage Reduction New Missed Lines %
helix.go 1 90.98%
Totals Coverage Status
Change from base Build 110: -0.2%
Covered Lines: 656
Relevant Lines: 721

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 113

  • 88 of 99 (88.89%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 90.985%

Changes Missing Coverage Covered Lines Changed/Added Lines %
webhooks.go 65 69 94.2%
helix.go 23 30 76.67%
Files with Coverage Reduction New Missed Lines %
helix.go 1 90.98%
Totals Coverage Status
Change from base Build 110: -0.2%
Covered Lines: 656
Relevant Lines: 721

💛 - Coveralls

@nicklaw5
Copy link
Owner Author

Merging this without documentation, simply because I believe I may want to change the API a little bit after doing some real-world testing.

@nicklaw5 nicklaw5 merged commit fde8cbd into master Dec 26, 2018
@nicklaw5 nicklaw5 deleted the add-webhook-support branch December 26, 2018 19:15
@nicklaw5 nicklaw5 mentioned this pull request Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants