Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure HTTP failure is handled in tests #86

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Ensure HTTP failure is handled in tests #86

merged 1 commit into from
Apr 25, 2021

Conversation

Scorfly
Copy link
Contributor

@Scorfly Scorfly commented Apr 25, 2021

No description provided.

@coveralls
Copy link

coveralls commented Apr 25, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 783079358

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.9%) to 95.77%
Totals Coverage Status
Change from base Build 775330813: 8.9%
Covered Lines: 883
Relevant Lines: 922
💛 - Coveralls

@nicklaw5
Copy link
Owner

@Scorfly are you able to explain this PR? I don't understand what it's trying to achieve. Is it purely to increase test code coverage?

@Scorfly
Copy link
Contributor Author

Scorfly commented Apr 25, 2021

On code coverage, http failure was never test on every func.

Yes, this PR only aim to increase code coverage

@nicklaw5 nicklaw5 merged commit 580849a into nicklaw5:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklaw5 nicklaw5 nicklaw5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scorfly @coveralls @nicklaw5