Fix expression progression logic and rounding #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expression progression logic manipulated the variable `i` in two ways:
- direct manipulation in the body for the `for` loop
- via the `enumerate` function, which would reset the value `i` every loop
iteration, overwriting whatever the body of the loop did to the value of
`i`
This caused evaluation bugs where parts of the expression were evaluated twice:
```python
>>> datemath.dm('2016-12-28T10:00:00||-1d/d')
<Arrow [2016-12-26T00:00:00+00:00]>
```
The `for` loop is replaced with a `while` loop, and all changes to our position
in the expression buffer are now done explicitly in the body of the loop.
|
Thank you taking the time to help fix this @rtkrruvinskiy ! Much appreciated! |
|
@rtkrruvinskiy , version 1.4.4 has been uploaded to pypi for for python 2x and python 3x. Let me know if you have any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expression progression logic manipulated the variable
iin two ways:forloopenumeratefunction, which would reset the valueievery loopiteration, overwriting whatever the body of the loop did to the value of
iThis caused evaluation bugs where parts of the expression were evaluated twice:
The
forloop is replaced with awhileloop, and all changes to our positionin the expression buffer are now done explicitly in the body of the loop.