-
Notifications
You must be signed in to change notification settings - Fork 505
Conversation
This looks good, thanks! Where was the flash being seen? Device or sim? |
Now that I'm integrating this into my app I'm also experiencing the flash issue with bluetooth. I've been thinking of a few different ways to solve this. Would be great to have some feedback.
|
Sorry I forgot to answer about the flash issue. Indeed this was happening when the dialog should not appear (conditions met) because the motion status check was an async request. This gave the time to the dialog to appear momentarily and then disappear resulting in a flash effect. The way I solved this was:
@felix-dumit Do you experience the flash with my pull request? |
@Navideck-fotis I did not try it, but from the changes you made I'm fairly confident it would solve it. Edit: @Navideck-fotis It didn't work for me with bluetooth. I ended up doing a different approach, I think it would be a good idea to do something similar for motion as well. |
I like the way this is handled in #57 versus relying on the implementation in the app (which is what I think you're suggested?). It should be simple enough to duplicate the async detection similar to bluetooth. Fix that up and we can pull this in. |
@nickoneill Done! I did my testing and everything works the same for me as before. |
Added CMMotionActivity support
Thanks! |
As promised this is my CMMotionActivity support contribution. I had to make a few minor changes to the way you present the dialog for the permissions to avoid a "flash" that was happening when all permissions were satisfied and the dialog shouldn't appear.