Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add middlewares #34

Merged
merged 5 commits into from
Jun 1, 2020
Merged

Add middlewares #34

merged 5 commits into from
Jun 1, 2020

Conversation

saitonakamura
Copy link
Contributor

No description provided.

nickovchinnikov
nickovchinnikov reviewed Jun 1, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
nickovchinnikov
nickovchinnikov reviewed Jun 1, 2020
View reviewed changes
src/rdx/store.ts Outdated Show resolved Hide resolved
@nickovchinnikov nickovchinnikov self-requested a review June 1, 2020 09:51
@nickovchinnikov
Copy link
Owner

А кроме того, чтобы добавить в проект, будут какие то примеры в крестиках-ноликах?

nickovchinnikov
nickovchinnikov requested changes Jun 1, 2020
View reviewed changes
Copy link
Owner

@nickovchinnikov nickovchinnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень уместно обновить readme.md

vvscode
vvscode reviewed Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@vvscode vvscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а как написать свой логгер ты им покажешь?

package.json Show resolved Hide resolved
@saitonakamura
Copy link
Contributor Author

Логгер будем писать на занятии в кодсендбоксе

@saitonakamura
Copy link
Contributor Author

saitonakamura commented Jun 1, 2020 •
edited
Loading

Очень уместно обновить readme.md

Да, сейчас сделаю пр с домашкой и вот

@saitonakamura
Copy link
Contributor Author

saitonakamura commented Jun 1, 2020 •
edited
Loading

А кроме того, чтобы добавить в проект, будут какие то примеры в крестиках-ноликах?

Нет, мне не хватило времени вписать это

@nickovchinnikov
Copy link
Owner

Нет, мне не хватило времени вписать это

один экшен сделать асинхронным с setTimeout?

@saitonakamura
Copy link
Contributor Author

saitonakamura commented Jun 1, 2020 •
edited
Loading

один экшен сделать асинхронным с setTimeout?

есть пример под рукой?

@nickovchinnikov
Copy link
Owner

какой например

поставить метку в поле?

nickovchinnikov
nickovchinnikov reviewed Jun 1, 2020
View reviewed changes
README.md
* Redux middlewares

[Pull request](https://github.com/nickovchinnikov/react-js-tutorial/pull/34) <br>
[Homework](https://github.com/nickovchinnikov/react-js-tutorial/pull/35) <br>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это дополнительная ДЗ, к той что в кабинете?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет, я обновил ту что в кабинете на эту

@saitonakamura
Copy link
Contributor Author

поставить метку в поле?

сделал

@saitonakamura saitonakamura merged commit efebce9 into nickovchinnikov:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvscode vvscode vvscode left review comments

@nickovchinnikov nickovchinnikov nickovchinnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saitonakamura @nickovchinnikov @vvscode