-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ember-power-select@4 and Ember Octane/Glimmer Components #78
Conversation
* Also fixes usage of onInput TODO * Update ember-try config (ember-power-select only works on Ember 3.11+) * Fix tests failures related to ember-infinity
Nice! This is great. I was also working on an upgrade to power-select 4 a while ago (but at that time it was still broken). Just noticed v4 stable was recently released. So what I think we can do best is get this out as v3 first, with a major bump, and then shortly after that also release a major version that is compatible with v4 & Octane (3.13+). |
* Refactor to glimmer components * Min Ember.js version is 3.13 instead of 3.12 because tracked properties are used
Thanks for your feedback. I already did the migration to power-select 4 and octane as it was easier to fix the tests like this. My changes break the API docs to some extent, as the list of supported arguments was removed from |
Oh, and we'd also need to update the docs to promote using angle-brackets + glimmer components. |
Also fix/update docs on global configuration.
Finally added/updated docs, so this should be ready for merging from my end. One thing I noticed (also while using this addon): It is a bit confusing that we use defaults for ember-infinity options ( |
@ttill thanks for all the work! I'll review this asap. If I remember correctly the main reason to change those defaults was because they matched my use case at the time (and the first releases did not have global settings). Happy to change it to match defaults though. Does need to be a separate PR so it shows up in the changelog correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing this 🎉
Breaking changes
power-select/options
could break stylingToDo