Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ember-power-select@4 and Ember Octane/Glimmer Components #78

Merged
merged 5 commits into from
Jun 4, 2020

Conversation

ttill
Copy link
Contributor

@ttill ttill commented Apr 8, 2020

  • Also fixes usage of onInput

Breaking changes

  • Following the change in power-select 3, event names are now camelCased
  • Use of glimmer components (in case components are subclassed)
  • Nested options list used to avoid having to copy code from power-select/options could break styling

ToDo

* Also fixes usage of onInput

TODO
* Update ember-try config (ember-power-select only works on Ember 3.11+)
* Fix tests failures related to ember-infinity
@nickschot
Copy link
Owner

Nice! This is great. I was also working on an upgrade to power-select 4 a while ago (but at that time it was still broken). Just noticed v4 stable was recently released. So what I think we can do best is get this out as v3 first, with a major bump, and then shortly after that also release a major version that is compatible with v4 & Octane (3.13+).

* Refactor to glimmer components
* Min Ember.js version is 3.13 instead of 3.12 because tracked
  properties are used
@ttill
Copy link
Contributor Author

ttill commented Apr 8, 2020

Thanks for your feedback. I already did the migration to power-select 4 and octane as it was easier to fix the tests like this.

My changes break the API docs to some extent, as the list of supported arguments was removed from ModelSelect. How do you want to proceed on this?

@ttill
Copy link
Contributor Author

ttill commented Apr 8, 2020

Oh, and we'd also need to update the docs to promote using angle-brackets + glimmer components.

@ttill ttill changed the title WIP Update ember-power-select to 3.x. Update to ember-power-select@4 and Ember Octance Apr 8, 2020
Also fix/update docs on global configuration.
@ttill ttill marked this pull request as ready for review April 20, 2020 06:29
@ttill
Copy link
Contributor Author

ttill commented Apr 20, 2020

Finally added/updated docs, so this should be ready for merging from my end.

One thing I noticed (also while using this addon): It is a bit confusing that we use defaults for ember-infinity options (pageParam, …) that differ from the defaults of ember-infinity itself. As the changes in this PR require a major version bump anyways, maybe the defaults should also be streamlined with ember-infinity?

@nickschot
Copy link
Owner

@ttill thanks for all the work! I'll review this asap. If I remember correctly the main reason to change those defaults was because they matched my use case at the time (and the first releases did not have global settings). Happy to change it to match defaults though. Does need to be a separate PR so it shows up in the changelog correctly.

@ttill ttill mentioned this pull request May 8, 2020
@nickschot nickschot changed the title Update to ember-power-select@4 and Ember Octance Update to ember-power-select@4 and Ember Octane/Glimmer Components Jun 4, 2020
Copy link
Owner

@nickschot nickschot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this 🎉

@nickschot nickschot merged commit 19c5784 into nickschot:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants