Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow - (dash) in process type #218

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Allow - (dash) in process type #218

merged 1 commit into from
Mar 10, 2020

Conversation

benspaulding
Copy link
Contributor

This change adds - (dash) to the list of valid characters for a process type. I propose this change because it seems to be the de facto Procfile standard.

I recently made a VS Code extension with syntax highlighting for Procfiles. In my testing I found that Honcho is the only Foreman clone that does not allow dashes in the process type. Allowing it would bring it in line with Foreman and the others.

Here is an excerpt from the project README that details my findings:


Foreman & Clones

The most used and robust are:

Others include:

  • node-foreman (Node) — n.b. How on earth is this not named “Noreman”? I insist on referring to it as such!
  • Shoreman (Shell)
  • forego (Go)

[…]

Procfile Foreman Honcho Goreman Noreman Shoreman forego
n0 … # # #
n1: …
n2: … # #
n3 : … # #
n4:…
n 5: … # # ✓ / ✗
# n6: … # # # # #
#n7: … # # # # #
n-8: … #
n9 :… # #
legend
valid process
comment / ignored #
error / hang

Closes #206.

@nickstenning
Copy link
Owner

Thanks! This LGTM. The build is failing because I need to remove support for Python 2.6, but I'm going to go ahead and merge this as everything other than 2.6 is passing.

@@ -19,7 +19,7 @@ source tree that contains zero or more lines of the form::
<process type>: <command>

The ``process type`` is a string which may contain alphanumerics and underscores
Copy link
Owner

@nickstenning nickstenning Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to update the prose here as well as the regex?

The ``process type`` is a string which may contain alphanumerics as well as
underscores and dashes (``[A-Za-z0-9_-]+``), and uniquely... [etc.]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that!

@nickstenning
Copy link
Owner

nickstenning commented Mar 10, 2020

Actually just spotted one change (to the text of the docs) and if you could make that change and rebase on master that would be fab. Rebasing should fix the Python 2.6 build failure thanks to #216.

The de facto Procfile standard allows this.

Closes #206.
@nickstenning
Copy link
Owner

Great, thanks! LGTM.

@nickstenning nickstenning merged commit b44d775 into nickstenning:master Mar 10, 2020
@benspaulding benspaulding deleted the dash-in-process-type branch June 5, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashes in process types
2 participants