Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to Github Actions #100

Merged
merged 17 commits into from
Nov 23, 2021
Merged

Conversation

nickw444
Copy link
Owner

@nickw444 nickw444 commented Nov 18, 2021

Provide a more accessible and less complex form of CI for this repo. The workflow definition file for Github Actions is more or less similar to Azure Pipelines (not a surprise, given they are likely sharing a lot under the hood given the MSFT acquisition of GitHub)

image

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #100 (b33f53c) into master (bcc68de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files           2        2           
  Lines         274      274           
  Branches       39       39           
=======================================
  Hits          246      246           
  Misses         13       13           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc68de...b33f53c. Read the comment docs.

@@ -1,5 +1,5 @@
[tox]
envlist = py35,py36,py37,py38,pypy3,lint,docs
envlist = py35,py36,py37,py38,py39,pypy3,lint,docs
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added py39 as discussed in the original PR for Azure Pipelines

if:
uses: pypa/gh-action-pypi-publish@master
with:
password: ${{ secrets.PYPI_API_TOKEN }}
Copy link
Owner Author

@nickw444 nickw444 Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have minted a new token for this and added it to the repo secrets.

@HeMan
Copy link
Collaborator

HeMan commented Nov 19, 2021

Looks good! I wonder if a bump to the pinned requirements in requirements-dev.txt should be done now as well.

@nickw444
Copy link
Owner Author

Looks good! I wonder if a bump to the pinned requirements in requirements-dev.txt should be done now as well.

I'll do a follow up PR once this is merged.

@nickw444 nickw444 merged commit f1f3a35 into master Nov 23, 2021
@nickw444 nickw444 deleted the nwhyte/migrate-to-github-actions branch November 23, 2021 09:43
@nickw444 nickw444 mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants