Pr #52
Merged
Pr #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diss, and added error checking to dissimilarity function for membship array
…ant from weighting function)
…ck of initial feature vector for attribute frequency calculation in ng_diss. Although this means that the encoded FV will not be freed by the GC! Alternative is to build a map of attribute frequencies at the beginning, but this adds unnecessary memory overhead if not predicting new data (e.g., just invoking fit or fit_predict). Therefore, I believe that maintaining a reference to the encoded FV is the best choice.
…ure and results are as expected.
# Conflicts: # kmodes/util/dissim.py
…m when predicting (and initializing)
# Conflicts: # setup.py
# Conflicts: # kmodes/kmodes.py # kmodes/kprototypes.py # kmodes/tests/test_kmodes.py
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.