Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added background to reflect the time: day, night, sunrise, sunset. #2

Merged
merged 1 commit into from
Jul 22, 2014

Conversation

mtt87
Copy link
Contributor

@mtt87 mtt87 commented Jul 21, 2014

I've added a background gradient to reflect the time during the day.
I've changed yesand no with capital letters.
I'm not sure but I think you spell "Yes it's ..." instead of "Yes is ..."
I've removed the seconds, not very useful imho.
The text is now bigger and centered 😄

@nicola
Copy link
Owner

nicola commented Jul 22, 2014

Nice, I will merge, however the coloring should not be in a if statement but there should be a maths function that for a given hour it gives an RGB.

nicola added a commit that referenced this pull request Jul 22, 2014
Added background to reflect the time: day, night, sunrise, sunset.
@nicola nicola merged commit a1b8141 into nicola:master Jul 22, 2014
@mtt87
Copy link
Contributor Author

mtt87 commented Jul 22, 2014

I thought about it actually but wasn't an easy expression :)) any help is appreciated with math! 😄—
Sent on the move from Mailbox, so apologies for brevity and errors!
Mattia

On Tue, Jul 22, 2014 at 8:56 PM, Nicola Greco notifications@github.com
wrote:

Merged #2.

Reply to this email directly or view it on GitHub:
#2 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants